ETQ usager utilisant un lecteur d'écran: la page de demande de confirmation de compte ne concentre pas le lecteur d'écran sur le champ pour renvoyer un mail de confirmation #10017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfo
force-pushed
the
US/a11y-after-signup
branch
from
83fd53d to
84ac6bf
Compare
mfo
changed the title
mfo
force-pushed
the
US/a11y-after-signup
branch
4 times, most recently
from
66dcb1b to
af03c97
Compare
colinux
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
top !
2 remarques indépendantes de cette PR (quoique) :
- comme pour la page de d'envoi de réinitialisation de mdp, ça me paraîtrait utile de mettre en évidence l'adresse email seule pour essayer d'alerter l'oeil s'il ya une typo dedans (en l'occurence la mettre en gras, sans mettre en gras le texte autour pour qu'elle ressorte bien)
- je pige pas bien pourquoi on met un input qui permet de ressaisir son email : on va pas saisir un autre email de toute façon !
Limite je me demande si c'est pas un nid à spam ? 👎apparemment non, changer d'email ne sert à rien, mais on pourrait se contenter d'un hidden input avec juste le bouton
mfo
force-pushed
the
US/a11y-after-signup
branch
2 times, most recently
from
03fd1fc to
59d7130
Compare
|
@colinux , merci pr tes retours. j'en ai profité pour continuer a simplifier (pas d'input, pas de barre horizontale, le bouton soumettre en 2eme niveau, le texte pas recu en muted mais dans un je trouve ça bien mieux, qu'en penses-tu ? |
mfo
force-pushed
the
US/a11y-after-signup
branch
from
59d7130 to
d50e4ae
Compare
… mail, otherwise screen reader goes straight to the input
mfo
force-pushed
the
US/a11y-after-signup
branch
from
d50e4ae to
48336f0
Compare
colinux
approved these changes
Feb 21, 2024
Merged
via the queue into
demarches-simplifiees:main
with commit Feb 21, 2024
5f5756a
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contexte: feedback de la culture
ETQ un usager utilisant un screen reader , apres la page de création de compte, je me retrouve imédiatement sur l'input pour redemander le lien de confirmation (sans passer par le contenu)
solution
apres:
avant: